Skip to content

Conversation

@davidwaroquiers
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.08%. Comparing base (6185224) to head (77a1542).

Files with missing lines Patch % Lines
src/jobflow_remote/cli/utils.py 77.77% 1 Missing and 1 partial ⚠️
src/jobflow_remote/cli/formatting.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #366      +/-   ##
===========================================
+ Coverage    74.03%   74.08%   +0.04%     
===========================================
  Files           51       51              
  Lines         7430     7446      +16     
  Branches      1207     1209       +2     
===========================================
+ Hits          5501     5516      +15     
  Misses        1516     1516              
- Partials       413      414       +1     
Flag Coverage Δ
all_local_tests 73.86% <93.02%> (+0.04%) ⬆️
all_tests 74.08% <93.02%> (+0.04%) ⬆️
db_tests 69.88% <90.69%> (-0.01%) ⬇️
integration_local_tests 47.73% <23.25%> (-0.01%) ⬇️
integration_remote_tests 26.60% <20.93%> (+0.03%) ⬆️
integration_tests 48.68% <23.25%> (-0.02%) ⬇️
unit_tests 26.83% <20.93%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/jobflow_remote/cli/flow.py 73.10% <100.00%> (+0.96%) ⬆️
src/jobflow_remote/cli/job.py 84.31% <100.00%> (+0.39%) ⬆️
src/jobflow_remote/cli/types.py 100.00% <100.00%> (ø)
src/jobflow_remote/jobs/daemon.py 67.68% <100.00%> (ø)
src/jobflow_remote/jobs/data.py 90.19% <100.00%> (+0.15%) ⬆️
src/jobflow_remote/jobs/jobcontroller.py 79.97% <100.00%> (-0.03%) ⬇️
src/jobflow_remote/cli/formatting.py 84.15% <92.30%> (-0.16%) ⬇️
src/jobflow_remote/cli/utils.py 64.51% <77.77%> (+0.35%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@gpetretto gpetretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Here are my initial comments.

Copy link
Member Author

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've made a few changes (still work in progress, up for discussion)

@davidwaroquiers davidwaroquiers changed the title WIP: Initial implementation of metadata in flow info. Initial implementation of metadata in flow info. Oct 20, 2025
@davidwaroquiers davidwaroquiers marked this pull request as ready for review October 20, 2025 12:20
Copy link
Contributor

@gpetretto gpetretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine with me. Just left to decide what to do about the shortening of the metadata.

Also maybe add a check on the metadata in the tests?

Handle jobs_info None case.
Copy link
Member Author

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@davidwaroquiers davidwaroquiers merged commit 73a1bbf into develop Oct 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants