-
Notifications
You must be signed in to change notification settings - Fork 16
Initial implementation of metadata in flow info. #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
checking daemon status. This should hopefully fix the random race-condition-based error that sometimes occur on the check_status.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #366 +/- ##
===========================================
+ Coverage 74.03% 74.08% +0.04%
===========================================
Files 51 51
Lines 7430 7446 +16
Branches 1207 1209 +2
===========================================
+ Hits 5501 5516 +15
Misses 1516 1516
- Partials 413 414 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Here are my initial comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've made a few changes (still work in progress, up for discussion)
jobs table as jf flow info FLOW_ID for the different verbose options.
Added sort on db_id in case update time is the same.
Fixed test flow info by adding that sort option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine with me. Just left to decide what to do about the shortening of the metadata.
Also maybe add a check on the metadata in the tests?
Handle jobs_info None case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
No description provided.