Skip to content

Conversation

@davidwaroquiers
Copy link
Member

The scheduler_type option config can now take a str (which is then directly converted to an existing qtoolkit scheduler io) or a dict based representation of a class.
Added the tests.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.15%. Comparing base (73a1bbf) to head (41562cc).

Files with missing lines Patch % Lines
src/jobflow_remote/config/base.py 75.00% 3 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (78.94%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (27.00%) is below the target coverage (50.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #383      +/-   ##
===========================================
+ Coverage    74.08%   74.15%   +0.07%     
===========================================
  Files           51       51              
  Lines         7446     7459      +13     
  Branches      1209     1212       +3     
===========================================
+ Hits          5516     5531      +15     
+ Misses        1516     1514       -2     
  Partials       414      414              
Flag Coverage Δ
all_local_tests 73.93% <78.94%> (+0.07%) ⬆️
all_tests 74.15% <78.94%> (+0.07%) ⬆️
db_tests 69.87% <36.84%> (-0.02%) ⬇️
integration_local_tests 47.72% <36.84%> (-0.01%) ⬇️
integration_remote_tests 26.61% <31.57%> (+<0.01%) ⬆️
integration_tests 48.67% <36.84%> (-0.01%) ⬇️
unit_tests 27.00% <78.94%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/jobflow_remote/testing/__init__.py 94.18% <100.00%> (+0.21%) ⬆️
src/jobflow_remote/config/base.py 83.83% <75.00%> (+0.63%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@gpetretto gpetretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I don't see the tests. Maybe they were not committed?
Also, it seems it contains the changes related to the flow info, so maybe better merge the other first?

@davidwaroquiers
Copy link
Member Author

Looks good to me, but I don't see the tests. Maybe they were not committed? Also, it seems it contains the changes related to the flow info, so maybe better merge the other first?

Duh, I forgot to commit the test indeed. Now it's done. For the flow info I don't know why ... maybe I started the branch from the flow info (I thought I had done it from develop but probably not ...). Let's wait for the merge of flow info then I'll merge it back here and push.

@gpetretto
Copy link
Contributor

I see that the unit test is failing. Indeed I think that inside the model_validator it should raise a ValueError:
https://docs.pydantic.dev/latest/concepts/validators/#raising-validation-errors

@davidwaroquiers davidwaroquiers merged commit e4792aa into develop Oct 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants