-
Notifications
You must be signed in to change notification settings - Fork 16
Added the possibility to have a custom scheduler io #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
checking daemon status. This should hopefully fix the random race-condition-based error that sometimes occur on the check_status.
jobs table as jf flow info FLOW_ID for the different verbose options.
Added sort on db_id in case update time is the same.
Fixed test flow info by adding that sort option.
(should be a subclass of BaseSchedulerIO).
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (78.94%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #383 +/- ##
===========================================
+ Coverage 74.08% 74.15% +0.07%
===========================================
Files 51 51
Lines 7446 7459 +13
Branches 1209 1212 +3
===========================================
+ Hits 5516 5531 +15
+ Misses 1516 1514 -2
Partials 414 414
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I don't see the tests. Maybe they were not committed?
Also, it seems it contains the changes related to the flow info, so maybe better merge the other first?
Handle jobs_info None case.
Duh, I forgot to commit the test indeed. Now it's done. For the flow info I don't know why ... maybe I started the branch from the flow info (I thought I had done it from develop but probably not ...). Let's wait for the merge of flow info then I'll merge it back here and push. |
|
I see that the unit test is failing. Indeed I think that inside the model_validator it should raise a ValueError: |
The scheduler_type option config can now take a str (which is then directly converted to an existing qtoolkit scheduler io) or a dict based representation of a class.
Added the tests.