Skip to content

Conversation

@davidwaroquiers
Copy link
Member

Also modified all the relevant methods to follow the same naming convention.
Also changed the batch directory for finished job runs to "run_finished" instead of "terminated".
Updated documentation.

Still to be done: upgrade method

Also modified all the relevant methods to follow the same naming
convention.
Also changed the batch directory for finished job runs to "run_finished"
instead of "terminated".
Updated documentation.
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.06%. Comparing base (99d4bd8) to head (ebc02c6).

❌ Your patch status has failed because the patch coverage (88.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (48.72%) is below the target coverage (50.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #384      +/-   ##
===========================================
+ Coverage    73.98%   74.06%   +0.08%     
===========================================
  Files           51       51              
  Lines         7430     7430              
  Branches      1207     1207              
===========================================
+ Hits          5497     5503       +6     
+ Misses        1522     1513       -9     
- Partials       411      414       +3     
Flag Coverage Δ
all_local_tests 73.84% <100.00%> (?)
all_tests 74.06% <100.00%> (+0.08%) ⬆️
db_tests 69.89% <92.00%> (?)
integration_local_tests 47.76% <88.00%> (+0.08%) ⬆️
integration_remote_tests 26.56% <36.00%> (ø)
integration_tests 48.72% <100.00%> (+0.08%) ⬆️
unit_tests 26.79% <24.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/jobflow_remote/cli/formatting.py 84.31% <ø> (ø)
src/jobflow_remote/config/base.py 83.20% <ø> (ø)
src/jobflow_remote/jobs/batch.py 85.45% <100.00%> (ø)
src/jobflow_remote/jobs/graph.py 8.69% <ø> (ø)
src/jobflow_remote/jobs/report.py 97.61% <ø> (ø)
src/jobflow_remote/jobs/run.py 74.02% <100.00%> (ø)
src/jobflow_remote/jobs/runner.py 78.33% <100.00%> (ø)
src/jobflow_remote/jobs/state.py 96.55% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants