Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise Changes from Native Addon Development #44

Merged
merged 1 commit into from
May 24, 2022

Conversation

CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented May 21, 2022

Description

Bring in change relevant to this repo from MatrixAI/TypeScript-Demo-Lib-Native#2 which came from #38

Tasks

  • 1. Updated codesee
  • 2. Updated .gitlab-ci.yaml to use staging
  • 3. The .npmignore now ignores all nix files
  • 4. Shorted the default.nix to use $packageName
  • 5. Updated jest.config.js to match how we are using jest-junit and global variable setup
  • 6. Removed the nix/ folder as leveldown fix is now in npm run pkg
  • 7. Replaced rm with rimraf to be portable with windows
  • 8. Now producing junit reports in CICD
  • 9. The pkg and node-gyp-build are just JS dependencies now
  • 10. We have scripts/pkg.js script that instruments pkg to bundle just what we need
  • 11. Fixed leveldb test on windows because it was not closing the database
  • 12. Producing arm64 builds for pkg bundle

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@ghost
Copy link

ghost commented May 21, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@CMCDragonkai CMCDragonkai changed the title WIP: Synchronise Changes from Native Addon Development Synchronise Changes from Native Addon Development May 24, 2022
@CMCDragonkai CMCDragonkai merged commit e976baf into staging May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant