Skip to content

fix: line on type extractions #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

lishaduck
Copy link
Contributor

Description

  • What does this PR change?
Screenshot 2025-05-07 at 12 58 36 PM

Screenshot 2025-05-07 at 12 52 40 PM

Copy link

changeset-bot bot commented May 7, 2025

🦋 Changeset detected

Latest commit: 5e7dc4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
expressive-code-twoslash Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 7, 2025

Deploy Preview for expressive-code-twoslash ready!

Name Link
🔨 Latest commit 5e7dc4a
🔍 Latest deploy log https://app.netlify.com/sites/expressive-code-twoslash/deploys/681c1237f7db300008cd78b3
😎 Deploy Preview https://deploy-preview-47--expressive-code-twoslash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented May 7, 2025

Open in StackBlitz

npm i https://pkg.pr.new/expressive-code-twoslash@47

commit: 5e7dc4a

Copy link
Member

@Adammatthiesen Adammatthiesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a changeset, looks great! Please add a changeset, then i will be happy to merge!

@Adammatthiesen
Copy link
Member

wait... now i'm confused? i dont see this on the effect website?
image

is this from a new branch and starlight version with the new starlight css?

@lishaduck
Copy link
Contributor Author

lishaduck commented May 7, 2025

wait... now i'm confused? i dont see this on the effect website?

Switching the effect site to use ^? instead of hardcoding, this is bug there (but not for hovers, only extraction).

@Adammatthiesen
Copy link
Member

wait... now i'm confused? i dont see this on the effect website?

Switching the effect site to use ^? instead of hardcoding, this is bug there (but not for hovers, only extraction

Can now confirm... im blind... and i need to remember which classes do what... 🤣 that is 100% the extraction class and i should have known that right away. makes sense!

@lishaduck lishaduck force-pushed the extractions-line branch from 6a80814 to 5e7dc4a Compare May 8, 2025 02:08
@lishaduck lishaduck requested a review from Adammatthiesen May 8, 2025 02:09
@Adammatthiesen
Copy link
Member

Thanks for adding the changeset! I will get this released here in the next hour-ish!

Side note... i really do love when its style changes... patch releases are sooo much better then minors 😝

@Adammatthiesen Adammatthiesen merged commit 1d29cdb into MatthiesenXYZ:main May 8, 2025
6 checks passed
@lishaduck lishaduck deleted the extractions-line branch May 8, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants