Ensure coordinator fallback preserves access when API is down

[MrIbrahem]

Summary

• normalize coordinator records from SQL with a default active flag to mirror the API payload
• provide a reusable coordinator index helper and rely on it in the header to treat missing active flags as enabled
• cover the new helpers with unit tests to guard the SQL fallback behaviour

Testing

• bash run_tests.sh (fails: vendor/bin/phpunit: No such file or directory)

---

https://chatgpt.com/codex/tasks/task_e_69086eec0c088322a0b6f5f351b28088

[coderabbitai]

Warning

Rate limit exceeded

@MrIbrahem has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 1 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 45575d4 and 1988530.

📒 Files selected for processing (3)

• src/backend/api_or_sql/funcs.php (1 hunks)
• src/header.php (1 hunks)
• tests/CoordinatorFallbackTest.php (1 hunks)

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch update-get_coordinator-to-include-active-flag

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @MrIbrahem, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the system's resilience by improving how coordinator access is managed, particularly during API outages. It introduces logic to normalize coordinator data fetched from SQL, ensuring that all records have an 'active' status, preventing unintended access restrictions. A new helper function centralizes the creation of an active status index, and comprehensive unit tests have been added to validate this critical fallback behavior.

Highlights

• Data Normalization: Introduced a new function, normalize_coordinator_rows, to ensure that all coordinator records, especially those fetched via SQL fallback, consistently include an 'active' flag, defaulting to '1' if not present, to match the API payload structure.
• Reusable Index Helper: Created coordinator_active_index, a reusable helper function that processes coordinator rows and returns an associative array mapping usernames to their 'active' status, ensuring consistent interpretation of active flags.
• Improved Fallback Logic: Modified get_coordinator to utilize the new normalization function, thereby safeguarding against issues where missing 'active' flags in SQL fallback data could inadvertently deny user access when the API is down.
• Unit Tests: Added a new test file, CoordinatorFallbackTest.php, with unit tests to cover the new normalize_coordinator_rows and coordinator_active_index functions, specifically verifying the default 'active' flag behavior and the correct indexing of coordinator statuses.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses an issue with the SQL fallback for coordinator data by ensuring the active flag is always present, mirroring the API's behavior. The introduction of the normalize_coordinator_rows and coordinator_active_index helper functions is a good approach, and they are well-covered by unit tests. My review includes a couple of suggestions to improve efficiency by avoiding redundant data normalization and to enhance code clarity in the new helper functions.

[gemini-code-assist]

The get_coordinator function now normalizes the data, and coordinator_active_index also normalizes the data. When called as coordinator_active_index(get_coordinator()) in src/header.php, the data is normalized twice. While this is not incorrect, it is inefficient. Consider removing the normalization from one of the functions to avoid redundant work. A good approach might be to remove this line and let coordinator_active_index be responsible for normalization, which aligns with its test case and its role as a 'reusable helper'.

[gemini-code-assist]

Since normalize_coordinator_rows is called at the beginning of this function, the active key is guaranteed to exist and be an integer for every array row. Therefore, the null coalescing operator (?? 0) and the (int) cast are redundant. The ?? 0 is also confusing as it suggests a default of 0, while normalize_coordinator_rows provides a default of 1 for missing active keys.

$coordinators[$user] = $row['active'];