Handle missing database config entries

src/backend/api_calls/mdwiki_sql.php

@@ -15,6 +15,7 @@
 //---
 use PDO;
 use PDOException;
+use RuntimeException;
 
 class Database
 {
@@ -45,7 +46,22 @@ private function set_db($server_name)
         // $ts_pw = posix_getpwuid(posix_getuid());
         // $ts_mycnf = parse_ini_file($ts_pw['dir'] . "/confs/db.ini");
         // ---
-        $ts_mycnf = parse_ini_file($this->home_dir . "/confs/db.ini");
+        $config_path = $this->home_dir . "/confs/db.ini";
+        $ts_mycnf = @parse_ini_file($config_path);
+        if ($ts_mycnf === false) {
+            throw new RuntimeException(sprintf('Database configuration file "%s" could not be read or parsed.', $config_path));
+        }
+
+        $required_keys = ['user'];
+        if ($server_name !== 'localhost') {
+            $required_keys[] = 'password';
+        }
+
+        foreach ($required_keys as $key) {
+            if (!array_key_exists($key, $ts_mycnf) || $ts_mycnf[$key] === '') {
+                throw new RuntimeException(sprintf('Database configuration is missing required "%s" entry in "%s".', $key, $config_path));
+            }
+        }
         // ---
         if ($server_name === 'localhost') {
             $this->host = 'localhost:3306';

tests/DatabaseConfigTest.php

@@ -0,0 +1,99 @@
+<?php
+
+declare(strict_types=1);
+
+use APICalls\MdwikiSql\Database;
+use FilesystemIterator;
+use PHPUnit\Framework\TestCase;
+use RecursiveDirectoryIterator;
+use RecursiveIteratorIterator;
+use RuntimeException;
+
+final class DatabaseConfigTest extends TestCase
+{
+    private ?string $originalHome = null;
+
+    protected function setUp(): void
+    {
+        $this->originalHome = getenv('HOME') !== false ? getenv('HOME') : null;
+    }
+
+    protected function tearDown(): void
+    {
+        if ($this->originalHome !== null) {
+            putenv('HOME=' . $this->originalHome);
+        } else {
+            putenv('HOME');
+        }
+    }
+
+    public function testSetDbThrowsExceptionWhenConfigMissing(): void
+    {
+        $tempHome = sys_get_temp_dir() . '/dbconfig_test_missing_' . uniqid();
+        $this->createTempHome($tempHome);
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('could not be read or parsed');
+
+        try {
+            new Database('localhost');
+        } finally {
+            $this->cleanupTempHome($tempHome);
+        }
+    }
+
+    public function testSetDbThrowsExceptionWhenPasswordMissing(): void
+    {
+        $tempHome = sys_get_temp_dir() . '/dbconfig_test_incomplete_' . uniqid();
+        $this->createTempHome($tempHome, ['user' => 'exampleuser']);
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('password');
+
+        try {
+            new Database('tools');
+        } finally {
+            $this->cleanupTempHome($tempHome);
+        }
+    }
+
+    private function createTempHome(string $path, array $config = []): void
+    {
+        $configDir = $path . '/confs';
+        if (!is_dir($configDir)) {
+            mkdir($configDir, 0777, true);
+        }
+
+        putenv('HOME=' . $path);
+
+        if ($config !== []) {
+            $ini = '';
+            foreach ($config as $key => $value) {
+                $ini .= sprintf("%s = \"%s\"\n", $key, $value);
+            }
+            file_put_contents($configDir . '/db.ini', $ini);
+        }
+    }
+
+    private function cleanupTempHome(string $path): void
+    {
+        if (!is_dir($path)) {
+            return;
+        }
+
+        $items = new RecursiveIteratorIterator(
+            new RecursiveDirectoryIterator($path, FilesystemIterator::SKIP_DOTS),
+            RecursiveIteratorIterator::CHILD_FIRST
+        );
+
+        foreach ($items as $item) {
+            if ($item->isDir()) {
+                @rmdir($item->getPathname());
+            } else {
+                @unlink($item->getPathname());
+            }
+        }
+
+        @rmdir($path);
+    }
+}