Draft
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6555 +/- ##
=========================================
Coverage 29.03% 29.03%
- Complexity 15156 15160 +4
=========================================
Files 2836 2836
Lines 279292 279295 +3
Branches 49237 49233 -4
=========================================
+ Hits 81098 81101 +3
Misses 192821 192821
Partials 5373 5373 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Feb 16, 2025
Member
|
Going to approve this, but we should check with CGL if melee weapons can have these quirks. Going to try and get an answer before merge. |
Collaborator
Author
|
Yeah not sure if you can make a club more accurate?(add a scope or grip tape). These are checks to see if a club has the quirk, the adding/removing of quirk not touched. |
Collaborator
|
@HammerGS it's been nearly a year, do we have any answer from CGL? |
Member
Nada but I'll see what I can do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6554
Added modifier checks from weaponAttackAction to clubAttackAction.
Quick copy paste of already implemented checks.