Implement Industrial Elevators

[HammerGS]

Summary

Implements player-controlled industrial elevators per BattleTech rules, distinct from the existing Solaris 7 random "moving walls" elevator system.

Key Features

• New terrain type: INDUSTRIAL_ELEVATOR (type 60) - separate from Solaris ELEVATOR (type 36)
• Player-controlled movement: Units on the platform can ascend/descend at 1 MP per level
• Platform tracking: Elevator platform position persists across turns
• Shaft boundaries: Configurable shaft top/bottom limits from terrain data
• Capacity system: Elevators have tonnage limits (encoded in terrain)
• Client-server sync: Platform state synchronized via UPDATE_INDUSTRIAL_ELEVATORS packet

Terrain Encoding

industrial_elevator::

• shaftBottom: Lowest level of shaft (can be negative for basements)
• encoded: (shaftTop << 8) | capacityTons - top level and capacity in one value

Example: industrial_elevator:-4:50 = shaft from -4 to 0, 500 ton capacity

Files Changed

New Files:

• megamek/src/megamek/common/IndustrialElevator.java - Elevator state model
• megamek/src/megamek/server/IndustrialElevatorProcessor.java - End-phase processing
• megamek/src/megamek/common/actions/CallElevatorAction.java - Future: call elevator from adjacent hex
• megamek/src/megamek/common/moves/ElevatorAscendStep.java - Ascend movement step
• megamek/src/megamek/common/moves/ElevatorDescendStep.java - Descend movement step

Modified Files:

• Terrains.java - Added INDUSTRIAL_ELEVATOR constant
• MoveStepType.java - Added ELEVATOR_ASCEND, ELEVATOR_DESCEND
• MoveStep.java - Elevator movement validation
• MovePath.java - Elevator step handling
• Game.java - Industrial elevator state storage
• TWGameManager.java - Initialization and sync methods
• MovePathHandler.java - Server-side movement processing, fall logic
• MovementDisplay.java - UI buttons for elevator control
• Client.java - Receive elevator updates
• PacketCommand.java - New packet type
• report-messages.properties - Elevator movement reports

Board/Tileset Files:

• 32x17 Heliport - Lift.board - Updated to use industrial_elevator terrain
• StandardIndustrialElevator.tileinc - Tileset mappings
• saxarba.tileset, hq_saxarba.tileset - Graphics entries

How It Works

1. Initialization: TWGameManager scans board for INDUSTRIAL_ELEVATOR terrain, creates IndustrialElevator objects
2. Movement Phase: When unit is on elevator platform, Up/Down buttons enabled based on shaft bounds
3. Elevator Movement: Platform moves WITH the unit (1 MP cost per level)
4. State Sync: After each move, server sends updated elevator state to all clients
5. Persistence: Platform position preserved across turns (fixed reinitialization bug)

Test Plan

• Elevator buttons enable when standing on elevator platform
• Elevator buttons respect shaft boundaries (top/bottom limits)
• Platform position persists across multiple turns
• Movement costs 1 MP per level
• Both ascend and descend work correctly
• Client receives platform updates after server processes move

Notes

• This system is intentionally separate from ElevatorProcessor (Solaris 7 random elevators)
• The "Call Elevator" feature (from adjacent hexes) is stubbed but not yet implemented in UI
• Fall-into-shaft logic exists but needs additional testing
• Includes data and a test board

TODO

• Map Editor
• Need to figure out how to use the Saxarba Elevators
• Need to have Player Specific Controls

[Copilot]

Pull request overview

This PR implements player-controlled industrial elevators as distinct from the existing Solaris 7 random elevator system. The implementation adds a new terrain type (INDUSTRIAL_ELEVATOR) with platform state tracking, movement validation, and client-server synchronization.

Key Changes:

• New industrial elevator system with player-controlled movement costing 1 MP per level
• Elevator state management including platform position, shaft bounds, and tonnage capacity
• Movement phase integration with UI buttons and server-side validation
• End-phase automatic elevator movement toward queued calls

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 17 comments.

Show a summary per file

File	Description
IndustrialElevator.java	Core elevator model with platform tracking, capacity checking, and call queue management
IndustrialElevatorProcessor.java	End-phase processor for initializing elevators and handling automatic platform movement
CallElevatorAction.java	Action for calling elevators from adjacent hexes (stubbed for future use)
ElevatorAscendStep.java, ElevatorDescendStep.java	Movement step handlers for elevator ascent/descent
MoveStep.java	Validation logic for elevator movement steps
MovePathHandler.java	Server-side movement processing with platform updates and fall detection
Game.java	Storage and retrieval methods for industrial elevators
TWGameManager.java	Initialization and client synchronization for elevators
MovementDisplay.java	UI button enablement logic for elevator controls
Client.java	Packet handling for elevator state updates
Terrains.java, MoveStepType.java, PacketCommand.java	New constants for elevator terrain, move types, and packets
IndustrialElevatorTest.java, IndustrialElevatorMovementTest.java	Comprehensive unit tests for elevator functionality
report-messages.properties, messages.properties	Localized strings for elevator reports and UI

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.