Fix Dazzle mode persisting when option is disabled (Fixes MekHQ #8700)#7959
Open
Fix Dazzle mode persisting when option is disabled (Fixes MekHQ #8700)#7959
Conversation
Fixes MekHQ #8700 Root cause: LaserWeapon.adaptToGameOptions() added the "Dazzle" mode when the gothic_dazzle_mode option was enabled, but never removed it when disabled. This caused lasers to retain Dazzle mode even after unchecking the option. Fix: Add else block to remove "Dazzle" and "Pulse Dazzle" modes when the option is disabled, following the same pattern used by other weapon modes in Weapon.adaptToGameOptions(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
HammerGS
added
AI Generated Fix
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where laser weapons retained Dazzle mode even after disabling the Gothic Dazzle Mode option. The root cause was that LaserWeapon.adaptToGameOptions() only added the modes when enabled but never removed them when disabled.
Changes:
- Added else block to remove "Dazzle" and "Pulse Dazzle" modes when the Gothic Dazzle Mode option is disabled
- Updated copyright year to 2026
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
LaserWeapon.adaptToGameOptions()added the "Dazzle" mode when the gothic_dazzle_mode option was enabled, but never removed it when disabled. This caused lasers to retain Dazzle mode even after unchecking the option.Changes
LaserWeapon.adaptToGameOptions()- Add else block to remove "Dazzle" and "Pulse Dazzle" modes when option is disabledFiles Changed
megamek/src/megamek/common/weapons/lasers/LaserWeapon.java- Add mode removal logicTested
Fixes MegaMek/mekhq#8700