Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.50.0] Ships with broken shell scripts #5183

Open
7 tasks done
WeaverThree opened this issue Nov 9, 2024 · 3 comments
Open
7 tasks done

[0.50.0] Ships with broken shell scripts #5183

WeaverThree opened this issue Nov 9, 2024 · 3 comments
Labels
Build Issue PR's related to project building i.e Gradle

Comments

@WeaverThree
Copy link
Collaborator

Prerequisites and Pre-Issue Checklist

  • I'm reporting the issue to the correct repository:

  • MegaMek

  • MegaMekLab

  • MekHQ

  • I've tested the issue against at least the latest MILESTONE version

  • I've asked on the MegaMek Discord about the error

  • I've reviewed the BattleTech rules and MekHQ documentation, and I've confirmed that something isn't working as intended.

  • I've searched the Github tracker and haven't found the issue listed

Severity *

High (Major Disruption): A major feature is broken or incorrect, but a workaround exists.

Brief Description *

There are several problems with the shell scripts in the release .tar.gz

These files need the execute flag set:

MegaMek.sh
MegaMekLab.sh
MekHQ.sh
bin/MegaMek
bin/MegaMekLab

(bin/MekHQ was already set correctly)

These files have the wrong line endings

MegaMek.sh
MegaMekLab.sh
MekHQ.sh

Which means they won't run at first but a dos2unix fixes them.

These problems do not exist in the nightly. I'm not sure if that's because someone fixed them or because the nightlies build in a linux environment on github and the release was possibly built on someone's windows computer? That would also explain why the nightly has the duplicate file problem in bin and the release does not, the windows build environment wouldn't allow it to happen.

Steps to Reproduce

Download .tar.gz from megamek website on a linux machien
tar zxvf it
Examine resulting files

Operating System *

Linux

Java Version *

17.0.12

MekHQ Suite Version *

v0.50.0

Custom MekHQ Version

No response

Attach Files

No response

Final Checklist

  • I've checked to make sure that this issue has not already been filed
  • I'm reporting only one issue in this ticket for clarity and focus
@repligator repligator added the Build Issue PR's related to project building i.e Gradle label Nov 9, 2024
@HammerGS
Copy link
Member

HammerGS commented Nov 9, 2024

I build the releases on a Windows machine.

@repligator
Copy link
Collaborator

Issue still present in 50.01 release.

@HammerGS
Copy link
Member

Not likely to get a fix till Tex is back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Issue PR's related to project building i.e Gradle
Projects
None yet
Development

No branches or pull requests

3 participants