Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to change tech bases for battle armor in the Mek Lab causes a null pointer error #5186

Open
7 tasks done
BrandonSmith16 opened this issue Nov 10, 2024 · 9 comments

Comments

@BrandonSmith16
Copy link

BrandonSmith16 commented Nov 10, 2024

Prerequisites and Pre-Issue Checklist

  • I'm reporting the issue to the correct repository:

  • MegaMek

  • MegaMekLab

  • MekHQ

  • I've tested the issue against at least the latest MILESTONE version

  • I've asked on the MegaMek Discord about the error

  • I've reviewed the BattleTech rules and MekHQ documentation, and I've confirmed that something isn't working as intended.

  • I've searched the Github tracker and haven't found the issue listed

Severity *

High (Major Disruption): A major feature is broken or incorrect, but a workaround exists.

Brief Description *

image
image
Best i can tell the issue is related to the game attempting to equip weapons/armor into the battle claw slot. This has been an issue since 0.49.7 or 49.14 I forget which.

Steps to Reproduce

Load a battle armor unit into the hangar. Load the unit into the lab. Attempt to change the tech base.

Sometimes you can fix this by manually removing the weapon/armor that it places in the battle armor claw location
(Tengu Yin Lon Plasma; Swap from Advanced to Standard)

It will almost always occur if you swap between clan and IS but might not occur if you swap to mixed IS or Mixed Clan.
Examples include the sloth(swapping to clan) and the gnome(Swapping to IS).

This also sometimes occurs when you try to swap between advanced, experimental and standard.

Examples include the kanazuchi[Standard] (Swapping to advanced or experimental from standard)
and Nephilim[Plasma] (Swapping from Advanced to standard)

These units are just examples given to make replicating the issue easier, the issue is incredibly widespread.

Operating System *

Windows 10

Java Version *

17.7

MekHQ Suite Version *

v0.50.0

Custom MekHQ Version

No response

Attach Files

No response

Final Checklist

  • I've checked to make sure that this issue has not already been filed
  • I'm reporting only one issue in this ticket for clarity and focus
@HammerGS
Copy link
Member

Can you attach the logs please.

@BrandonSmith16
Copy link
Author

Where are they located?

@HammerGS
Copy link
Member

In the Logs folder, we'd need the three of them

@BrandonSmith16
Copy link
Author

@HammerGS
Copy link
Member

09:26:37,037 ERROR [mekhq.MekHQ] {AWT-EventQueue-0}
mekhq.MekHQ.lambda$main$1(MekHQ.java:294) - Uncaught Exception Detected
java.lang.NullPointerException: Cannot read field "internalName" because "manipulator" is null
	at megameklab.ui.battleArmor.BAStructureTab.setManipulator(BAStructureTab.java:290)
	at megameklab.ui.battleArmor.BAStructureTab.actionPerformed(BAStructureTab.java:276)

@HammerGS HammerGS added the Bug label Nov 10, 2024
@BrandonSmith16
Copy link
Author

Does that mean the bug where it tries to put weapons/armor in battle armor claw slots is probably another issue entirely?
image

@BrandonSmith16
Copy link
Author

That part is much less of an issue since you can just...remove the weapon/armor it places there.
image

@HammerGS
Copy link
Member

If I had to guess, the Manipulators aren't selected on the first tab. But we have significant issues with refits especially in the non-mech units. It's a goal of the 0.50.x to fix and improve these but we are just too early in the process.

Some players have had success making the unit in standalone MML, then doing it as a refit kit rather than trying to use MML in MekHQ

@BrandonSmith16
Copy link
Author

Some players have had success making the unit in standalone MML, then doing it as a refit kit rather than trying to use MML in MekHQ

That has been the workaround since I started playing a few years ago, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants