issue: 4424775 Improve KTLS compliancy with kernel in setsockopt(TCP_ULP) #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kernel supports TLS ULP only for a TCP socket in the ESTABLISHED state. NVME ULP is a vendor-specific and is already skipped. Since the shadow socket cannot be established for an offloaded socket, we always expect TCP_ULP to fail in kernel. Therefore, don't call it. Signed-off-by: Dmytro Podgornyi <[email protected]>
Fail setsockopt() instead of resetting the TLS offload state. This change improve robustness and makes the behavior be compliant to kernel. Signed-off-by: Dmytro Podgornyi <[email protected]>
pasis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve KTLS compliancy with kernel.
setsockopt(TCP_ULP) has different behavior than kernel if an application calls it multiple times by mistake.
Skip calling to kernel, because kernel will always fail this option for the shadow socket.
What
Improve KTLS compliancy with kernel.
Why ?
Improve KTLS compliancy with kernel.
Change type
What kind of change does this PR introduce?
Check list