issue: 4367367 Improvements to the XLIO Ultra API #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasis
force-pushed
the
product_xlio_zc_api2
branch
from
101d3a2 to
9f7e4dc
Compare
BasharRadya
reviewed
Jul 22, 2025
| return nullptr; | ||
| } | ||
| si->set_xlio_socket(&attr); | ||
| m_p_group->add_socket(si); |
There was a problem hiding this comment.
Both
m_p_group->add_socket(si);
-> set_socket
and
socket_internal
int fd2 = g_p_fd_collection->addsocket(fd, __domain, __type, check_offload);
will
m_p_sockfd_map[fd] = si;
but i guess there is no harm in that, but duplicate work.
There was a problem hiding this comment.
good point, I will take a look. If this is not an issue we can leave it.
BasharRadya
reviewed
Jul 22, 2025
BasharRadya
reviewed
Jul 22, 2025
BasharRadya
reviewed
Jul 22, 2025
yes, with the new arch we will likely introduce eventfd and it can be used as the fd resource holder. So currently lets use either socket or epfd until eventfd is added. |
BasharRadya
approved these changes
Jul 22, 2025
|
bot:retest |
XLIO has a feature to avoid kernel shadow socket allocation for incoming TCP sockets. Reuse this feature for the XLIO zerocopy API sockets. This reduces system resources consumption and pushes theoretical incoming sockets limit from 500K to 1M per process. Note, 5T steering can provide more strict limitation. Signed-off-by: Dmytro Podgornyi <[email protected]>
This function updates the group attributes including the callbacks. When listen sockets support was added the function wasn't updated with the new callback support. Signed-off-by: Dmytro Podgornyi <[email protected]>
Signed-off-by: Dmytro Podgornyi <[email protected]>
Signed-off-by: Dmytro Podgornyi <[email protected]>
xlio_buf if referenced in a event callback declaration. Define it above in the header. Signed-off-by: Dmytro Podgornyi <[email protected]>
Signed-off-by: Dmytro Podgornyi <[email protected]>
pasis
force-pushed
the
product_xlio_zc_api2
branch
from
9f7e4dc to
33563bc
Compare
Ultra API shouldn't use locks by default unless XLIO_GROUP_FLAG_SAFE polling group is used. Also a socket should inherit the locking scheme of the new group during the 2-step migration. Signed-off-by: Dmytro Podgornyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor improvements and fixes for the XLIO Ultra API.
Consistent doxygen documentation
What
Minor improvements, fixes, documentation updates
Why ?
Fixes and quality improvements
Change type
What kind of change does this PR introduce?
Check list