issue: 4424629 Suppress duplicate IP warning for link-local IPv6 #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot:retest |
3 similar comments
|
bot:retest |
|
bot:retest |
|
bot:retest |
pasis
reviewed
Jul 21, 2025
| @@ -245,7 +245,9 @@ void net_device_table_mgr::update_tbl() | |||
| sa_family_t family) { | |||
| auto it = net_device_map.find(ip->local_addr); | |||
| if (it != net_device_map.end()) { | |||
| duplicate_ips.insert(ip->local_addr.to_str(family)); | |||
| if (!(family == AF_INET6 && ip->local_addr.is_linklocal(family))) { | |||
There was a problem hiding this comment.
please put a comment with motivation for this exception. Mention that logical interfaces can have duplicate IPv6 link-local and the warning is not relevant because (1) user needs to specify interface along with link-local address and (2) XLIO doesn't support IPv6 link-local at the moment
Refrain from printing duplicate IP warning for unsupported link-local IPv6. Signed-off-by: Bashar Abdelgafer <[email protected]>
BasharRadya
force-pushed
the
supress_dup_ip_link_local
branch
from
e1f1e1f to
e78133d
Compare
pasis
approved these changes
Jul 21, 2025
|
bot:retest |
3 similar comments
|
bot:retest |
|
bot:retest |
|
bot:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refrain from printing duplicate IP warning for unsupported link-local IPv6.
Description
Please provide a summary of the change.
What
Subject: what this PR is doing in one line.
Why ?
Justification for the PR. If there is existing issue/bug please reference.
How ?
It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.
Change type
What kind of change does this PR introduce?
Check list