chore: update spectrum-x manifests #1547
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rollandf
added
the
on hold
Pull Request Test Coverage Report for Build 15583805418Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Spectrum‑X manifests and related test and state code to reflect a refactored operator design and new configuration patterns. Key changes include:
- Updates to test code to use a separate catalog variable and revised manifest object counts.
- Modifications to state rendering to incorporate static configuration and a new CNI binary directory.
- Removal of obsolete Spectrum‑X configuration references and manifest files.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/state/state_spectrumx_test.go | Updated tests to use a dedicated catalog and adjusted manifest object expectations |
| pkg/state/state_spectrumx.go | Added static config support and CNI binary directory in runtime spec; removed Deployment watch source |
| manifests/state-spectrum-x-operator/0050-flowcontroller-ds.yaml | Added an init container for copying the rail CNI binaries and new volume mount based on CNI bin directory |
| manifests/state-spectrum-x-operator/0040-spectrumx-operator.yaml | Removed obsolete deployment manifest |
| manifests/state-spectrum-x-operator/0020-role.yaml, hack/release.yaml, and others | Minor updates to RBAC rules and version bump to support the changes in operator configuration |
Comments suppressed due to low confidence (3)
pkg/state/state_spectrumx_test.go:47
- The manifest object count expectation was reduced from 5 to 4. Please add a brief comment or ensure that the test clearly reflects the updated catalog contents so future maintainers understand the change.
Expect(len(objs)).To(Equal(4))
pkg/state/state_spectrumx.go:134
- The watch source for 'Deployment' was removed. Confirm that no dependencies rely on it, and if necessary, update the documentation to reflect this design decision.
wr["Deployment"] = &appsv1.Deployment{}
manifests/state-spectrum-x-operator/0040-spectrumx-operator.yaml:1
- The entire Spectrum‑X operator deployment manifest was removed. Ensure that external dependencies and documentation are updated to reflect this removal.
-apiVersion: apps/v1
almaslennikov
previously approved these changes
Jun 6, 2025
heyvister1
reviewed
Jun 9, 2025
| } | ||
|
|
||
| // NicClusterPolicySpec defines the desired state of NicClusterPolicy | ||
| // +kubebuilder:pruning:PreserveUnknownFields |
There was a problem hiding this comment.
Is this related to SpectrumX changes or its more of a general change in NCP?
heyvister1
reviewed
Jun 9, 2025
| }) | ||
|
|
||
| Context("should render", func() { | ||
| It("Kubernetes manifests", func() { | ||
| cr := getSpectrumXOperator() | ||
| objs, err := ts.renderer.GetManifestObjects(ts.context, cr, ts.catalog, testLogger) | ||
| objs, err := ts.renderer.GetManifestObjects(ts.context, cr, catalog, testLogger) |
There was a problem hiding this comment.
What is the difference between ts.catalog and catalog? if you go with catalog, I still see below usage of it.
There was a problem hiding this comment.
catalog is a var, not the default one.
Updated to use it in all places
almaslennikov
previously approved these changes
Jun 11, 2025
Signed-off-by: Fred Rolland <[email protected]>
almaslennikov
approved these changes
Jun 12, 2025
|
/retest-nic_operator_helm |
e0ne
approved these changes
Jun 12, 2025
|
/retest-nic_operator_helm |
1 similar comment
|
/retest-nic_operator_helm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.