Skip to content

feat: Refresh app tokens #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

feat: Refresh app tokens #201

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fe014fc
Refresh app tokens
sicarul May 7, 2023
654c958
Merge branch 'main' into upstream-renew-private-tokens
sicarul May 9, 2023
32e8057
Merge branch 'main' into upstream-renew-private-tokens
sicarul May 9, 2023
7dd5416
Merge branch 'main' into upstream-renew-private-tokens
sicarul May 11, 2023
ed64f19
Remove type definition so mypy passes
sicarul May 11, 2023
3adc0e9
Move typing definition for token to the top of the class
sicarul May 16, 2023
1f638ae
Merge branch 'main' into upstream-renew-private-tokens
sicarul May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tap_github/authenticator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def __init__(self, stream: RESTStream) -> None:
self.active_token: Optional[TokenRateLimit] = (
choice(list(self.tokens_map.values())) if len(self.tokens_map) else None
)
self.last_private_key_token_refresh: datetime = None
self.last_private_key_token_refresh = None
# Refresh tokens from private key if it was supplied
if self.active_token is None:
self.active_token = self.refresh_app_token()
Expand Down