Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): pre-commit autoupdate #191

Merged
merged 2 commits into from
May 20, 2024
Merged

chore(deps): pre-commit autoupdate #191

merged 2 commits into from
May 20, 2024

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented May 20, 2024

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

edgarrmondragon
edgarrmondragon approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the changes that pyproject-fmt is making here

@edgarrmondragon edgarrmondragon merged commit 287613d into main May 20, 2024
2 of 9 checks passed
@edgarrmondragon edgarrmondragon deleted the pre-commit-ci-update-config branch May 20, 2024 16:54
@HlebKrah
Copy link

@edgarrmondragon Hi! This changes are broke this package. You can see this in checks for example

@edgarrmondragon edgarrmondragon mentioned this pull request May 22, 2024
Merged
edgarrmondragon added a commit that referenced this pull request May 22, 2024
@edgarrmondragon
fix: Fixed pyproject.toml (#192)
858c7b0 
See
#191 (comment)
@edgarrmondragon
Copy link
Member

@edgarrmondragon Hi! This changes are broke this package. You can see this in checks for example

@HlebKrah thanks for the heads up! #192 should fix it.

@HlebKrah
Copy link

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MeltanoLabs Overview
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HlebKrah @edgarrmondragon