Skip to content

Conversation

edgarrmondragon
Copy link
Member

@edgarrmondragon edgarrmondragon commented Dec 3, 2024

@edgarrmondragon edgarrmondragon self-assigned this Dec 3, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/exclude-information-schema branch from 6c83b46 to ce81f75 Compare December 3, 2024 20:40
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/singer-sdk-0.43 branch 2 times, most recently from b87c075 to a9c0660 Compare December 3, 2024 23:31
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/exclude-information-schema branch from ce81f75 to 6833840 Compare December 3, 2024 23:33
@edgarrmondragon edgarrmondragon marked this pull request as draft December 4, 2024 15:52
@visch
Copy link
Member

visch commented Dec 5, 2024

@edgarrmondragon By default this makes sense, but there's been a number of time's this has been super useful

@edgarrmondragon
Copy link
Member Author

@edgarrmondragon By default this makes sense, but there's been a number of time's this has been super useful

@visch oh that's interesting! would you mind elaborating? do you mean for debugging or for something else?

@visch
Copy link
Member

visch commented Dec 5, 2024

@edgarrmondragon By default this makes sense, but there's been a number of time's this has been super useful

@visch oh that's interesting! would you mind elaborating? do you mean for debugging or for something else?

Had folks use it for schema change reports to see when a schema is updated from the information schema, also when new tables get added. It's been a few wonky use cases but they have happened and it's a big pain to modify the taps that already exist that don't have this functionality. A config value is probably fine as well 🤷

@edgarrmondragon
Copy link
Member Author

edgarrmondragon commented Dec 6, 2024

@edgarrmondragon By default this makes sense, but there's been a number of time's this has been super useful

@visch oh that's interesting! would you mind elaborating? do you mean for debugging or for something else?

Had folks use it for schema change reports to see when a schema is updated from the information schema, also when new tables get added. It's been a few wonky use cases but they have happened and it's a big pain to modify the taps that already exist that don't have this functionality. A config value is probably fine as well 🤷

Makes sense, I've opened meltano/sdk#2799 for that. I won't be able to fit in the current v0.43 milestone, so it'll have to wait. Maybe this PR will just wait until that's available too.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/singer-sdk-0.43 branch from a9c0660 to 325511d Compare December 9, 2024 17:17
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/exclude-information-schema branch from 6833840 to 6a0ce07 Compare December 9, 2024 18:10
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/singer-sdk-0.43 branch from 325511d to e200dd3 Compare December 10, 2024 15:42
Base automatically changed from edgarrmondragon/feat/singer-sdk-0.43 to main December 10, 2024 16:18
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/exclude-information-schema branch from 6a0ce07 to 63faaa8 Compare December 10, 2024 16:35
@edgarrmondragon edgarrmondragon added the Singer SDK Requires upstream Singer SDK changes label Dec 10, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/exclude-information-schema branch from 63faaa8 to b045466 Compare April 29, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Singer SDK Requires upstream Singer SDK changes

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants