apply ModernCppStarter to the lib and fix memory leaks #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 21, 2023 19:02
applied this https://github.com/filipdutescu/modern-cpp-template because current cmake sucks. Please, do not lie about that this is can be not header-only lib. It IS header only lib. Maybe it does precompiling headers ( including header to cpp and nothing to do), but in case of the lib, where there are a lot of templates, it's nearly useless. Also removed test that was checking ability of linking the library, because it's pointless, if there's more useful test which needs the lib. If those fails, we can see it in compilation failing at preprocessing stage. Edited README with adding explanation how to using the lib. I didn't changed the code of the lib, except in fmtlog.h it adds fmtlog-inl.h anytime, because it's actually a header-only lib and let's not say it can be not header only just by adding one header to a .cc file.
|
Good to have to support installing without needing to manually copy anything. |
Open
Arniiiii
changed the title
Arniiiii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: it maybe fixes memory leaks mentioned at #100
applied this
https://github.com/TheLartians/ModernCppStarter
because current cmake script at the project literally sucks.
Please, do not lie about that this can be not header-only lib. It IS header only lib. Maybe it does precompiling headers ( including header to cpp and nothing to do), but in case of the lib, where there are a lot of templates, it's nearly useless.
Also removed test that was checking ability of linking the library, because it's pointless, if there's more useful test which needs the lib. If those fails, we can see it in compilation failing at preprocessing stage.
Edited README with adding explanation how to use the lib.
I didn't changed the code of the lib, except in fmtlog.h it adds fmtlog-inl.h anytime, because it's actually a header-only lib and let's not say it can be not header only just by adding one header to a .cc file.