Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scancode.bbclass: [Request for review]: OI-2 Adding bbclass for scancode #1057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

scancode.bbclass: [Request for review]: OI-2 Adding bbclass for scancode #1057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions meta-mentor-staging/classes/scancode.bbclass
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# We use scancode utlity for extacting licence information.
# scancode itself is an OSS Utlitity.
# For more informaiton https://github.com/nexB/scancode-toolkit
# scancode is used from HOSTTOOLS.

SCANCODE_FORMAT ?= "html-app"
EXT = "${@'html' if d.getVar('SCANCODE_FORMAT', True) == 'html-app' else 'json'}"

do_scancode() {
mkdir -p ${DEPLOY_DIR_IMAGE}/scancode
if [ -d "${S}" ]; then
scancode ${S} --format ${SCANCODE_FORMAT} ${DEPLOY_DIR_IMAGE}/scancode/${PN}.${EXT}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention is to no longer write directly to DEPLOY_DIR_IMAGE, but instead allow the sstate state management code to keep track of what it's installed and uninstall to/from that location. I'd suggest doing the same here, following the same pattern as that used by deploy.bbclass.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon further consideration, I'd also suggest moving this to its own subdirectory of DEPLOY_DIR, rather than cluttering up DEPLOY_DIR_IMAGE with content that isn't directly bound to an image.

fi
}

addtask scancode after do_patch

do_scancode_oss() {
echo "We are done running scancode"
}

do_scancode_oss[recrdeptask] = "do_scancode_oss do_scancode"
do_scancode_oss[nostamp] = "1"
addtask do_scancode_oss after do_scancode
Copy link
Member

@kergoth kergoth Mar 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The do_scancode_oss task can be removed. Bitbake supports running a specific task against all dependencies recursively on its own now: bitbake --runall=scancode console-image.