Skip to content

Add a minimal test suite #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
9999years wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a minimal test suite #61

9999years wants to merge 1 commit into from

Conversation

@9999years
Copy link
Member

@9999years 9999years commented Mar 15, 2024

No description provided.

@github-actions github-actions bot added the patch A patch-level change (backwards-compatible bug fixes) label Mar 15, 2024
@9999years 9999years mentioned this pull request Mar 16, 2024
Merged
@9999years 9999years force-pushed the tests branch 19 times, most recently from 0b3103f to a59ac43 Compare January 15, 2026 18:29
9999years added a commit that referenced this pull request Jan 15, 2026
@9999years
Run Cargo tests in GitHub Actions
67fbeff 
Note: Most of CI is run through garnix.io, but the Nix sandboxing they use
doesn't play nice with our test suite, so we'll try running it through
GitHub Actions.

We need to merge this separately so we can even test the test suite in
CI :(

See: #61
@9999years 9999years mentioned this pull request Jan 15, 2026
Merged
@9999years 9999years force-pushed the tests branch 7 times, most recently from 8e3c84b to fa96c7f Compare January 15, 2026 20:00
@9999years
Copy link
Member Author

9999years commented Jan 15, 2026

ok i did a bunch of work on this. it's pretty nice! significant limitations though:

  • nushell is UNTESTABLE, you cannot pipe input to it, it HATES being run in a pexpect-like environment. my understanding is that they have literally zero tests for their interactive ui upstream because of this, so i'm not sure why i should test my software's compatibility with nushell either. strongly considering ripping support for nushell out of nix-your-shell entirely over this tbh
  • i have a decent ability to test, like, running nix-your-shell fish nix -- develop ..., which is okay, but i really want end-to-end tests that start by sourcing the output of nix-your-shell fish env. so there's some future work
  • i don't have thorough test cases yet, so i need to write the tests themselves, but the harness is looking solid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

patch A patch-level change (backwards-compatible bug fixes)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@9999years