fix: don't break the monkeypatch chain #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 9246029. 🟢 All jobs passed!But CI Insights is watching 👀 |
sileht
force-pushed
the
devs/sileht/hook-fix/Ibe9bb54be35290b3cc0dda89ce713096afdb7e03
branch
from
f235c7f to
270a85b
Compare
Greesb
previously approved these changes
Sep 4, 2025
sileht
force-pushed
the
devs/sileht/hook-fix/Ibe9bb54be35290b3cc0dda89ce713096afdb7e03
branch
from
270a85b to
2b2c466
Compare
Mainly libs change this hook, a common practice is to run the existing hook after or before the custom code. This avoids breaking monkeypatching of other libs. Change-Id: Ibe9bb54be35290b3cc0dda89ce713096afdb7e03
sileht
force-pushed
the
devs/sileht/hook-fix/Ibe9bb54be35290b3cc0dda89ce713096afdb7e03
branch
from
2b2c466 to
9246029
Compare
Greesb
approved these changes
Sep 4, 2025
mergify
bot
deleted the
devs/sileht/hook-fix/Ibe9bb54be35290b3cc0dda89ce713096afdb7e03
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly libs change this hook, a common practice is to run the existing
hook after or before the custom code.
This avoids breaking monkeypatching of other libs.