fix: put some default options to stack group #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Changelog requirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
|
Those options are related to the `stack` group and should not be computed for other groups since they may break others calls. --debug is still a global option: $ mergify --debug stack push This does not work anymore: $ mergify --token foobar stack push Global stack options are to be passed like this: $ mergify stack --token foobar push
leocnp
force-pushed
the
fix-default-options
branch
from
743d4ae to
a289198
Compare
DouglasBlackwood
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global options
--tokenand--github-serverare related to thestackgroup and should not have their defaults computed for other groups since they may break others commands.--debug is still a global option:
$
mergify --debug stack pushThis does not work anymore:
$
mergify --token foobar stack pushGlobal
stackoptions are to be passed like this:$
mergify stack --token foobar push