Skip to content

Conversation

@shane-t
Copy link
Member

@shane-t shane-t commented Dec 17, 2024

No description provided.

@shane-t shane-t requested review from a team and Montoya as code owners December 17, 2024 15:14
@shane-t shane-t marked this pull request as draft December 17, 2024 15:15
@shane-t shane-t force-pushed the sto/sip-30/multi-SRP branch from ba75faa to 9571b7a Compare December 18, 2024 11:25
@shane-t shane-t changed the title Draft: SIP-30 - request entropy from multiple sources SIP-30 Dec 18, 2024
@shane-t shane-t changed the title SIP-30 SIP-30: Entropy Source Identifiers Dec 18, 2024
@shane-t shane-t force-pushed the sto/sip-30/multi-SRP branch from 9571b7a to 3d7bdaf Compare December 18, 2024 11:27
@shane-t shane-t marked this pull request as ready for review December 18, 2024 11:37
@Montoya
Copy link
Contributor

Montoya commented Dec 18, 2024

Why does this have to be a new API? If it involves a new optional parameter, it can be backwards compatible. If the Snap does not include the parameter in the request, default to the legacy behavior. If the parameter is included, then use that parameter to identify the entropy source.

@shane-t
Copy link
Member Author

shane-t commented Dec 20, 2024

Why does this have to be a new API? If it involves a new optional parameter, it can be backwards compatible. If the Snap does not include the parameter in the request, default to the legacy behavior. If the parameter is included, then use that parameter to identify the entropy source.

That's the general idea. We retain all the snap_get*Entropy methods but include a new source parameter

@shane-t
Copy link
Member Author

shane-t commented Dec 20, 2024

@Montoya I've added a section describing the behaviour if the parameter is not included

@shane-t shane-t requested a review from Mrtenz January 7, 2025 14:51
FrederikBolding
FrederikBolding previously approved these changes Jan 7, 2025
@shane-t shane-t force-pushed the sto/sip-30/multi-SRP branch from 1c78f81 to b50371a Compare January 8, 2025 16:28
FrederikBolding
FrederikBolding previously approved these changes Jan 9, 2025
Co-authored-by: Maarten Zuidhoorn <[email protected]>
@FrederikBolding FrederikBolding merged commit bea5f93 into main Jan 10, 2025
3 checks passed
@FrederikBolding FrederikBolding deleted the sto/sip-30/multi-SRP branch January 10, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants