Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP-5792 methods #284

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add EIP-5792 methods #284

wants to merge 8 commits into from

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Feb 12, 2025 •
edited
Loading

Added specs for the EIP-5792 methods, and tested that they display correctly via the OpenRPC parser in the interactive API reference docs.

Note: I avoid using schemas inherited from ethereum/execution-apis in some cases because the parser sometimes overwrites method-specific parameter descriptions with inherited descriptions. This is a parser issue we can fix later.

@alexandratran alexandratran marked this pull request as ready for review February 12, 2025 01:21
@alexandratran alexandratran requested a review from a team as a code owner February 12, 2025 01:21
vandan
vandan reviewed Feb 13, 2025
View reviewed changes
vandan
vandan reviewed Feb 13, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandan vandan vandan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandratran @vandan