feat(getMostRecentTags): add fetchRemote option to allow disabling remote fetching #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mikesposito
reviewed
Oct 28, 2024
Comment on lines
27
to
32
| if (typeof fetchRemote !== 'boolean' || fetchRemote) { | ||
| await runCommand('git', ['fetch', '--tags']); | ||
| } |
Member
There was a problem hiding this comment.
Could we cover this with some tests?
Contributor
Author
There was a problem hiding this comment.
This entire module is currently untested, unfortunately...
Contributor
Author
There was a problem hiding this comment.
basic unit test for the new behavior has been added, alongside a new run option to facilitate testing.
legobeat
force-pushed
the
offline-mode
branch
from
e3c697b to
091dd8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
getMostRecentTagswill perform agit fetch --tags, failing if the remote fetching does.This adds a new option
fetchRemote(defaulttrue). Setting it tofalsedisables the remote-fetching.Motivation: Allow running https://github.com/MetaMask/create-release-branch/ in an unauthenticated context.