-
-
Notifications
You must be signed in to change notification settings - Fork 4
Bump @metamask/eslint-config from 11.1.0 to 14.1.0 #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @metamask/eslint-config from 11.1.0 to 14.1.0 #256
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| "@arethetypeswrong/cli": "^0.15.3", | ||
| "@lavamoat/allow-scripts": "^2.1.0", | ||
| "@metamask/eslint-config": "^11.1.0", | ||
| "@metamask/eslint-config": "^14.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: ESLint Config Upgrade: Major Incompatibilities
Upgrading @metamask/eslint-config to ^14.1.0 introduces breaking incompatibilities. Version 14.x requires ESLint ^9.11.0 (currently ^8.40.0), eslint-plugin-import-x ^4.3.0 (currently has eslint-plugin-import ^2.26.0), eslint-plugin-jsdoc ^50.2.4 (currently ^39.6.2), and eslint-plugin-promise ^7.1.0 (not installed). Additionally, ESLint 9 only supports flat configs, but the project uses .eslintrc.js legacy format. The config is also now pure ESM, incompatible with the CommonJS .eslintrc.js file.
4b4f4df to
5f8ce95
Compare
Bumps [@metamask/eslint-config](https://github.com/MetaMask/eslint-config) from 11.1.0 to 14.1.0. - [Release notes](https://github.com/MetaMask/eslint-config/releases) - [Commits](https://github.com/MetaMask/eslint-config/compare/@metamask/[email protected]...@metamask/[email protected]) --- updated-dependencies: - dependency-name: "@metamask/eslint-config" dependency-version: 14.1.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
5f8ce95 to
4584ecc
Compare
| "@arethetypeswrong/cli": "^0.15.3", | ||
| "@lavamoat/allow-scripts": "^2.1.0", | ||
| "@metamask/eslint-config": "^11.1.0", | ||
| "@metamask/eslint-config": "^14.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Incompatible peer dependencies with updated eslint-config
The @metamask/eslint-config was bumped to v14.1.0 while the related configs (@metamask/eslint-config-jest, @metamask/eslint-config-nodejs, @metamask/eslint-config-typescript) remain at v11.1.0. These v11 packages have peer dependencies requiring @metamask/eslint-config: ^11.0.0, which is incompatible with v14. Additionally, v14.1.0 requires eslint: ^9.11.0, eslint-plugin-import-x, eslint-plugin-jsdoc: ^50.2.4, and eslint-plugin-promise: ^7.1.0, but the package.json still has eslint: ^8.40.0, eslint-plugin-import (not import-x), and eslint-plugin-jsdoc: ^39.6.2 with no eslint-plugin-promise.
|
Superseded by #265. |
Bumps @metamask/eslint-config from 11.1.0 to 14.1.0.
Release notes
Sourced from
@metamask/eslint-config's releases.... (truncated)
Commits
a948d02Release/14.1.0 (#421)e3b8fa7ci: Fix publish workflow (#420)ddd0557Revert "Release/14.1.0" (#419)fe384a0Release/14.1.0 (#411)26bae79chore: Add dependency lint and fix lint issues (#412)6ac9442chore: Update release documentation (#408)e214271chore: Update@metamask/create-release-branchto^4.1.3(#409)cd9425aRevert "feat(typescript): Update type import specifier rules" (#407)bf6fe5bUpdate codeowners to@MetaMask/core-platform(#406)773e3bfBump vite from 5.4.18 to 5.4.19 in the npm_and_yarn group across 1 directory ...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Upgrade @metamask/eslint-config to v14.1.0 and refresh lockfile with ESLint 9-related dependencies.
@metamask/eslint-configinpackage.jsonto^14.1.0.yarn.lockto resolve new transitive deps:@eslint/js@^9.11.0andglobals@^15.9.0.eslint@^9.11.0,eslint-config-prettier@^9.1.0,eslint-plugin-import-x@^4.3.0,eslint-plugin-jsdoc@^50.2.4,eslint-plugin-prettier@^5.2.1,eslint-plugin-promise@^7.1.0,prettier@^3.3.3.Written by Cursor Bugbot for commit 4584ecc. This will update automatically on new commits. Configure here.