Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"@metamask/eslint-config": "^11.1.0",
"@metamask/eslint-config-jest": "^11.1.0",
"@metamask/eslint-config-nodejs": "^11.1.0",
"@metamask/eslint-config-typescript": "^11.1.0",
"@metamask/eslint-config-typescript": "^14.1.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incompatible peer dependencies after version bump

Bumping @metamask/eslint-config-typescript to version 14.1.0 creates incompatible peer dependencies. Version 14.x requires @metamask/eslint-config at ^14.1.0 (currently ^11.1.0), eslint at ^9.11.0 (currently ^8.40.0), typescript-eslint at ^8.24 (currently using deprecated @typescript-eslint/eslint-plugin and @typescript-eslint/parser at ^5.42.1), eslint-plugin-import-x at ^4.3.0 (currently using eslint-plugin-import at ^2.26.0), eslint-plugin-jsdoc at ^50.2.4 (currently ^39.6.2), and eslint-import-resolver-typescript at ^3.6.3 (missing). Additionally, ESLint 9 requires flat config format while the project uses legacy .eslintrc.js format. This will cause ESLint to fail.

Additional Locations (2)

Fix in Cursor Fix in Web

"@ts-bridge/cli": "^0.6.3",
"@types/cross-spawn": "^6.0.2",
"@types/diff": "^5.0.0",
Expand Down
31 changes: 21 additions & 10 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,13 @@ __metadata:
languageName: node
linkType: hard

"@eslint/js@npm:^9.11.0":
version: 9.39.1
resolution: "@eslint/js@npm:9.39.1"
checksum: b651930aec03a5aef97bc144627aebb05070afec5364cd3c5fd7c5dbb97f4fd82faf1b200b3be17572d5ebb7f8805211b655f463be96f2b02202ec7250868048
languageName: node
linkType: hard

"@gar/promisify@npm:^1.1.3":
version: 1.1.3
resolution: "@gar/promisify@npm:1.1.3"
Expand Down Expand Up @@ -841,7 +848,7 @@ __metadata:
"@metamask/eslint-config": ^11.1.0
"@metamask/eslint-config-jest": ^11.1.0
"@metamask/eslint-config-nodejs": ^11.1.0
"@metamask/eslint-config-typescript": ^11.1.0
"@metamask/eslint-config-typescript": ^14.1.0
"@octokit/rest": ^20.0.0
"@ts-bridge/cli": ^0.6.3
"@types/cross-spawn": ^6.0.2
Expand Down Expand Up @@ -899,16 +906,20 @@ __metadata:
languageName: node
linkType: hard

"@metamask/eslint-config-typescript@npm:^11.1.0":
version: 11.1.0
resolution: "@metamask/eslint-config-typescript@npm:11.1.0"
"@metamask/eslint-config-typescript@npm:^14.1.0":
version: 14.1.0
resolution: "@metamask/eslint-config-typescript@npm:14.1.0"
dependencies:
"@eslint/js": ^9.11.0
peerDependencies:
"@metamask/eslint-config": ^11.0.0
"@typescript-eslint/eslint-plugin": ^5.42.1
"@typescript-eslint/parser": ^5.42.1
eslint: ^8.27.0
typescript: ~4.8.4
checksum: 86f20303730fce7a2d6944d133e3d4cf745816bdc202fd17ebd341e4937777c662e80b3c1496a8da7d5e06e39518dec3206c4a4e872d9491f423e792bcdf56db
"@metamask/eslint-config": ^14.1.0
eslint: ^9.11.0
eslint-import-resolver-typescript: ^3.6.3
eslint-plugin-import-x: ^4.3.0
eslint-plugin-jsdoc: ^50.2.4
typescript: ">=4.8.4 <5.9.0"
typescript-eslint: ^8.24
checksum: 44d39572f17aa131c50ba316dda9fbfbdef564f25c60dc5773a03146538031c377e024fc9759a493e695bcf4f581ef8aac518328f891b1c18a59241396243cda
languageName: node
linkType: hard

Expand Down
Loading