Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lock ci #13

Merged
merged 5 commits into from
Dec 12, 2024
Merged

fix: lock ci #13

merged 5 commits into from
Dec 12, 2024

Conversation

darioAnongba
Copy link
Contributor

Fix CI by locking (using the .lock file), as by default cargo uses the .toml. This lead to the CI breaking when BDK updated to beta.6.

@darioAnongba darioAnongba self-assigned this Dec 12, 2024
ccharly
ccharly approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, having a Cargo.lock seems better anyway! :)

@darioAnongba darioAnongba merged commit 720027c into main Dec 12, 2024
9 checks passed
@darioAnongba darioAnongba deleted the fix/ci branch December 12, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccharly ccharly ccharly approved these changes

Assignees

@darioAnongba darioAnongba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darioAnongba @ccharly