Skip to content

chore: remove snap feature #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Dec 17, 2024
Merged

chore: remove snap feature #18

merged 21 commits into from
Dec 17, 2024

Conversation

darioAnongba
Copy link
Contributor

The snap feature was implemented as a way to test the implementation of the WalletPersister trait but it doesn't make sense to exist in this library for the following reasons:

  • Snaps are specific to MetaMask and have no place in an environment agnostic package.
  • Storage should not happen in the background as the decision on where and how to store the data belongs to the infrastructure layer of the application.

@darioAnongba darioAnongba self-assigned this Dec 16, 2024
@darioAnongba darioAnongba changed the base branch from main to feat/changeset December 16, 2024 12:34
Base automatically changed from feat/changeset to main December 16, 2024 16:33
@darioAnongba darioAnongba merged commit a0edcee into main Dec 17, 2024
7 checks passed
@darioAnongba darioAnongba deleted the chore/remove-snap branch December 17, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants