WIP: Expose MultichainApiClient provider with a transport adapter without needing to connect first
#45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The solana connect package will require the
MultichainApiClientprovider to be available before the SDK is connected to the wallet in order to announce itself via a wallet standard event. This is mainly problematic in the case of the MWP flow in which a connection cannot be automatically established without user input. Additionally, the MWP Transport cannot be used as-is with theMultichainApiClientdespite having similar interfaces because the deeplinking/qr code logic lives in a different layer (MultichainSDK). This implies that all requests must flow throughMultichainSDKin order to correctly trigger any MWP related flows.This PR achieves that by introducing a new
MultichainApiClientWrapperTransportwhich is meant slowly as a wrapper around theMultichainSDKthat can be used to instantiate and exposeMultichainApiClientwithout the dapp having to establish a connection first. TheMultichainApiClientWrapperTransportremaps requests to their corresponding methods on theMultichainSDKor respond with mock empty/error responses where appropriate.MultichainApiClientWrapperTransportis not meant to be used with anything other than theMultichainApiClientThis can be tested by accessing
window.mmsdk.providerNOTE:
wallet_invokeMethodis broken currently.References
Checklist