-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: implement MM Connect Multichain Analytics #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sing through wallet_invokeMethod
…rating from metamask-sdk-analytics-api repo
| eventProperties.integration_type, | ||
| ); | ||
| analytics.track('mmconnect_initialized', { | ||
| dapp_id: 'some-non-global-property', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if I missed this in our earlier call, but shouldn't this be a global property rather than a discreet event? Lets loop back w/ @adamceresko since I think we may want to fully remove the mmconnect_initialized event since I think it will be mostly noise (it will happen on every page load where MMConnect is installed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After convo with @adamceresko, he preferred to keep this initialized event in, but you can sync and we loop back to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I'll loop back with him on this. But in any case I'd think dapp_id should be a global property no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝🏾 it actually is, the test file property value is just misleading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed here 683fec5
Explanation
This PR implements all of the remaining events/properties found in the event’s schema that are not yet in the mm-connect package.
References
Checklist