Skip to content

Conversation

@ffmcgee725
Copy link
Member

@ffmcgee725 ffmcgee725 commented Nov 25, 2025

Explanation

This PR implements all of the remaining events/properties found in the event’s schema that are not yet in the mm-connect package.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ffmcgee725 ffmcgee725 marked this pull request as ready for review November 26, 2025 11:17
@ffmcgee725 ffmcgee725 requested a review from a team as a code owner November 26, 2025 11:17
wenfix
wenfix previously approved these changes Nov 26, 2025
eventProperties.integration_type,
);
analytics.track('mmconnect_initialized', {
dapp_id: 'some-non-global-property',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I missed this in our earlier call, but shouldn't this be a global property rather than a discreet event? Lets loop back w/ @adamceresko since I think we may want to fully remove the mmconnect_initialized event since I think it will be mostly noise (it will happen on every page load where MMConnect is installed)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After convo with @adamceresko, he preferred to keep this initialized event in, but you can sync and we loop back to this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'll loop back with him on this. But in any case I'd think dapp_id should be a global property no?

Copy link
Member Author

@ffmcgee725 ffmcgee725 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed here 683fec5

@ffmcgee725 ffmcgee725 merged commit d3e1a16 into main Nov 27, 2025
40 checks passed
@ffmcgee725 ffmcgee725 deleted the jc/WAPI-865 branch November 27, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants