Skip to content

Conversation

@wenfix
Copy link
Contributor

@wenfix wenfix commented Dec 1, 2025

Explanation

In order for a connect request to succeed on Metamask Mobile via MultichainCore, it needs to have a dapp.name and dapp.url properties configured as they're enforced in this mobile validation function. This PR marks them as mandatory.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@wenfix wenfix requested a review from a team as a code owner December 1, 2025 13:35
adonesky1
adonesky1 previously approved these changes Dec 2, 2025
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jiexi
jiexi previously approved these changes Dec 2, 2025
@adonesky1 adonesky1 dismissed stale reviews from jiexi and themself via 4b1fc2e December 2, 2025 21:17
@adonesky1 adonesky1 force-pushed the fix/core-dapp-properties branch from a2a3b60 to 4b1fc2e Compare December 2, 2025 21:17
@adonesky1 adonesky1 force-pushed the fix/core-dapp-properties branch from 4b1fc2e to 72caa70 Compare December 2, 2025 21:18
@adonesky1 adonesky1 merged commit ea2d469 into main Dec 2, 2025
9 checks passed
@adonesky1 adonesky1 deleted the fix/core-dapp-properties branch December 2, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants