-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: make MultichainCore's dapp name and url properties mandatory #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
reviewed
Dec 1, 2025
jiexi
reviewed
Dec 2, 2025
jiexi
reviewed
Dec 2, 2025
adonesky1
reviewed
Dec 2, 2025
adonesky1
previously approved these changes
Dec 2, 2025
Contributor
adonesky1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jiexi
previously approved these changes
Dec 2, 2025
a2a3b60 to
4b1fc2e
Compare
4b1fc2e to
72caa70
Compare
jiexi
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
In order for a
connectrequest to succeed on Metamask Mobile viaMultichainCore, it needs to have adapp.nameanddapp.urlproperties configured as they're enforced in this mobile validation function. This PR marks them as mandatory.References
Checklist