Skip to content

Conversation

@ffmcgee725
Copy link
Member

Explanation

In the Firefox Extension, when a dapp disconnects, the UI updates correctly, but attempting to reconnect does not prompt the wallet pop-up for permission granting.

This happens because createDupeReqFilterStream middleware is responsible for keeping track of IDs that have been recently seen and not respond to request incoming from these matching IDs.

the proposed fix here is bumping @metamask/multichain-api-client to make sure we make use of the fix in this PR.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ffmcgee725 ffmcgee725 requested a review from a team as a code owner December 4, 2025 12:24
wenfix
wenfix previously approved these changes Dec 4, 2025
Copy link
Contributor

@wenfix wenfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​multichain-api-client@​0.8.1 ⏵ 0.10.1100100100 +196 +3100

View full report

@ffmcgee725 ffmcgee725 merged commit fad67fa into main Dec 4, 2025
40 checks passed
@ffmcgee725 ffmcgee725 deleted the jc/WAPI-873/fix-rpc-request-with-id-already-seen-firefox-browser branch December 4, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants