feat: add connection id to simple deeplinks #63
Merged
+65
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiexi
changed the title
jiexi
changed the title
7 tasks
ffmcgee725
reviewed
Dec 5, 2025
packages/connect-multichain/src/multichain/rpc/requestRouter.ts
Outdated
Show resolved
Hide resolved
ffmcgee725
reviewed
Dec 5, 2025
ffmcgee725
reviewed
Dec 5, 2025
packages/connect-multichain/src/multichain/transports/mwp/index.ts
Outdated
Show resolved
Hide resolved
ffmcgee725
reviewed
Dec 5, 2025
ffmcgee725
reviewed
Dec 5, 2025
Member
ffmcgee725
left a comment
ffmcgee725
left a comment
There was a problem hiding this comment.
Left some feedback, and also we should address the broken unit tests
Co-authored-by: ffmcgee <[email protected]>
Co-authored-by: ffmcgee <[email protected]>
…link' into jl/add-session-id-to-simple-deeplink
Contributor
Author
|
no changelog because this is not developer or user facing |
adonesky1
reviewed
Dec 5, 2025
| const [activeSession] = await sessionStore.list(); | ||
| return activeSession; | ||
| } catch (error){ | ||
| // TODO: verify if this try catch is necessary |
Contributor
Author
There was a problem hiding this comment.
not yet. I looked at the code already, doesn't looks like this can throw, but not going to remove it out of abundance of safety
adonesky1
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
When deeplinking the user into the wallet for non-initial connection cases, the wallet has no idea which connection/session the user is opening the wallet from. In the case that the connection the dapp is using no longer exists on the wallet side, the user will sit in the wallet indefinitely waiting for a request that will never arrive.
This PR fixes that by including the connection id to the previously plain
metamask://connect/mwpdeeplink. It is nowmetamask://connect/mwp?id=CONN_ID_HERE. This will allow the wallet to prompt the user with an error toast if that connection no longer exists on the wallet side.References
See: MetaMask/metamask-mobile#23700
Checklist