Skip to content
Main

TransactionController networkClientId updates #6515

Sign in to view logs

TransactionController networkClientId updates

TransactionController networkClientId updates #6515

Triggered via pull request December 12, 2023 23:06
@jiexijiexi
synchronize #3652
transaction-multichain-jiexi-side-quest
Status Failure
Total duration 3m 3s
Artifacts –

main.yml

on: pull_request
Check workflows
6s
Check workflows
Matrix: Lint, build, and test / Prepare
Matrix: Lint, build, and test / Build
Matrix: Lint, build, and test / Lint
Matrix: Lint, build, and test / Test
Matrix: Lint, build, and test / Validate changelog
All jobs complete
0s
All jobs complete
Determine whether this is a release merge commit
0s
Determine whether this is a release merge commit
All jobs pass
0s
All jobs pass
Publish release  /  publish-release
Publish release / publish-release
Publish release  /  publish-npm-dry-run
Publish release / publish-npm-dry-run
Publish release  /  publish-npm
Publish release / publish-npm
Fit to window
Zoom out
Zoom in

Annotations

75 errors and 10 warnings
Lint, build, and test / Lint (20.x): packages/transaction-controller/src/TransactionController.ts#L97
There should be at least one empty line between import groups
Lint, build, and test / Lint (20.x): packages/transaction-controller/src/TransactionController.ts#L101
All imports in the declaration are only used as types. Use `import type`
Lint, build, and test / Lint (20.x): packages/transaction-controller/src/TransactionController.ts#L101
`@metamask/network-controller` import should occur before import of `@metamask/rpc-errors`
Lint, build, and test / Lint (20.x): packages/transaction-controller/src/TransactionController.ts#L400
@param path declaration ("options.getNetworkClientIdForDomain") root node name ("options") does not match previous real parameter name ("state")
Lint, build, and test / Lint (20.x): packages/transaction-controller/src/TransactionController.ts#L400
Missing JSDoc @param "options.getNetworkClientIdForDomain" description
Lint, build, and test / Lint (20.x): packages/transaction-controller/src/TransactionController.ts#L645
Missing JSDoc @param "opts.networkClientId" description
Lint, build, and test / Lint (20.x): packages/transaction-controller/src/TransactionController.ts#L912
Insert `;`
Lint, build, and test / Lint (20.x): packages/transaction-controller/src/TransactionController.ts#L1066
Insert `;`
Lint, build, and test / Lint (20.x): packages/transaction-controller/src/TransactionController.ts#L1067
Insert `;`
Lint, build, and test / Lint (20.x): packages/transaction-controller/src/TransactionController.ts#L1176
Missing JSDoc @param "networkClientId" declaration
Lint, build, and test / Test (16.x, @metamask/transaction-controller)
Process completed with exit code 1.
Lint, build, and test / Test (18.x, @metamask/queued-request-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (18.x, @metamask/keyring-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (18.x, @metamask/signature-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/build-utils)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/eth-json-rpc-provider)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/composable-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (18.x, @metamask/user-operation-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/accounts-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/accounts-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/controller-utils)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/controller-utils)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/notification-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/notification-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/polling-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/polling-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/json-rpc-middleware-stream)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/message-manager)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/message-manager)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/logging-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/base-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/rate-limit-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/rate-limit-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/transaction-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/transaction-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/json-rpc-engine)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/json-rpc-engine)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/user-operation-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/user-operation-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/phishing-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/phishing-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/permission-log-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/preferences-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/permission-log-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/preferences-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/network-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/network-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/signature-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/signature-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/selected-network-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/selected-network-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/permission-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/permission-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/keyring-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/keyring-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/queued-request-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/queued-request-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/name-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/name-controller)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/transaction-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (18.x, @metamask/transaction-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/gas-fee-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/gas-fee-controller)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/network-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (18.x, @metamask/network-controller)
The operation was canceled.
Lint, build, and test / Test (16.x, @metamask/network-controller)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (16.x, @metamask/network-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/assets-controllers)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (20.x, @metamask/assets-controllers)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/assets-controllers)
The job was canceled because "_16_x__metamask_transacti" failed.
Lint, build, and test / Test (18.x, @metamask/assets-controllers)
The operation was canceled.
Lint, build, and test / Build (20.x): packages/transaction-controller/src/TransactionController.ts#L47
File '/home/runner/work/core/core/packages/selected-network-controller/src/SelectedNetworkController.ts' is not under 'rootDir' '/home/runner/work/core/core/packages/transaction-controller/src'. 'rootDir' is expected to contain all source files.
Lint, build, and test / Build (20.x): packages/transaction-controller/src/TransactionController.ts#L47
File '/home/runner/work/core/core/packages/selected-network-controller/src/SelectedNetworkController.ts' is not listed within the file list of project '/home/runner/work/core/core/packages/transaction-controller/tsconfig.build.json'. Projects must list all files or use an 'include' pattern.
Lint, build, and test / Build (20.x)
Process completed with exit code 2.
All jobs pass
Process completed with exit code 1.
Lint, build, and test / Lint (20.x): packages/approval-controller/src/ApprovalController.test.ts#L725
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
Lint, build, and test / Lint (20.x): packages/approval-controller/src/ApprovalController.test.ts#L731
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
Lint, build, and test / Lint (20.x): packages/approval-controller/src/ApprovalController.test.ts#L739
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
Lint, build, and test / Lint (20.x): packages/approval-controller/src/ApprovalController.test.ts#L745
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
Lint, build, and test / Lint (20.x): packages/approval-controller/src/ApprovalController.test.ts#L751
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
Lint, build, and test / Lint (20.x): packages/approval-controller/src/ApprovalController.test.ts#L757
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
Lint, build, and test / Lint (20.x): packages/approval-controller/src/ApprovalController.test.ts#L765
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
Lint, build, and test / Lint (20.x): packages/approval-controller/src/ApprovalController.test.ts#L773
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
Lint, build, and test / Lint (20.x): packages/approval-controller/src/ApprovalController.test.ts#L786
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
Lint, build, and test / Lint (20.x): packages/approval-controller/src/ApprovalController.test.ts#L804
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator