Extract/fix FakeProvider for use among packages #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FakeProvider class is useful in tests because it allows you to pass a provider that doesn't make HTTP requests to a library such as `eth-query`. Previously, this class was only available in NetworkController tests. With this commit, you can use it anywhere.
3 tasks
…er (and thus eth-query)
legobeat
approved these changes
Nov 15, 2023
mcmire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The FakeProvider class is useful in tests because it allows you to pass a provider that doesn't make HTTP requests to a library such as
eth-query.Previously, this class was only available in NetworkController tests. We want to now start using it in other tests, specifically along with
eth-query. However, one problem I noticed is that it doesn't conform to SafeEventEmitterProvider completely. So this commit not only moves it to a more global location but also corrects its API so that it can be passed toeth-query.References
See discussion here: #2037 (comment)
Changelog
(No consumer-facing changes.)
Checklist