Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transactions from account snaps that should not be published #5045

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shane-t
Copy link
Member

@shane-t shane-t commented Dec 9, 2024

Explanation

Relates to this extension PR

Should not be merged; this is a demonstration

References

TBD

Changelog

@metamask/transaction-controller

  • CHANGED: Removed coupling of "Update custodial transactions" and MMI
  • ADDED: Before publish hook now receives raw transaction

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@shane-t shane-t force-pushed the MMI-5803-deferral-proposal-2 branch from 2f7ffb1 to e58ce4a Compare December 9, 2024 19:49
@shane-t
Copy link
Member Author

shane-t commented Dec 9, 2024

@metamaskbot publish-preview

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "20.0.0-preview-e58ce4ab",
  "@metamask-previews/address-book-controller": "6.0.1-preview-e58ce4ab",
  "@metamask-previews/announcement-controller": "7.0.1-preview-e58ce4ab",
  "@metamask-previews/approval-controller": "7.1.1-preview-e58ce4ab",
  "@metamask-previews/assets-controllers": "45.1.0-preview-e58ce4ab",
  "@metamask-previews/base-controller": "7.0.2-preview-e58ce4ab",
  "@metamask-previews/build-utils": "3.0.1-preview-e58ce4ab",
  "@metamask-previews/chain-controller": "0.2.0-preview-e58ce4ab",
  "@metamask-previews/composable-controller": "9.0.1-preview-e58ce4ab",
  "@metamask-previews/controller-utils": "11.4.3-preview-e58ce4ab",
  "@metamask-previews/ens-controller": "15.0.0-preview-e58ce4ab",
  "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-e58ce4ab",
  "@metamask-previews/gas-fee-controller": "22.0.1-preview-e58ce4ab",
  "@metamask-previews/json-rpc-engine": "10.0.1-preview-e58ce4ab",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-e58ce4ab",
  "@metamask-previews/keyring-controller": "19.0.0-preview-e58ce4ab",
  "@metamask-previews/logging-controller": "6.0.2-preview-e58ce4ab",
  "@metamask-previews/message-manager": "11.0.1-preview-e58ce4ab",
  "@metamask-previews/multichain": "1.0.0-preview-e58ce4ab",
  "@metamask-previews/name-controller": "8.0.1-preview-e58ce4ab",
  "@metamask-previews/network-controller": "22.0.2-preview-e58ce4ab",
  "@metamask-previews/notification-controller": "7.0.0-preview-e58ce4ab",
  "@metamask-previews/notification-services-controller": "0.14.0-preview-e58ce4ab",
  "@metamask-previews/permission-controller": "11.0.3-preview-e58ce4ab",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-e58ce4ab",
  "@metamask-previews/phishing-controller": "12.3.0-preview-e58ce4ab",
  "@metamask-previews/polling-controller": "12.0.1-preview-e58ce4ab",
  "@metamask-previews/preferences-controller": "15.0.0-preview-e58ce4ab",
  "@metamask-previews/profile-sync-controller": "2.0.0-preview-e58ce4ab",
  "@metamask-previews/queued-request-controller": "8.0.0-preview-e58ce4ab",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-e58ce4ab",
  "@metamask-previews/selected-network-controller": "20.0.0-preview-e58ce4ab",
  "@metamask-previews/signature-controller": "23.0.0-preview-e58ce4ab",
  "@metamask-previews/transaction-controller": "41.0.0-preview-e58ce4ab",
  "@metamask-previews/user-operation-controller": "20.0.0-preview-e58ce4ab"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant