Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(accouncement): Rename ControllerMessenger to Messenger #5092

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 20, 2024

Explanation

Rename ControllerMessenger to Messenger in the @metamask/announcement-controller package. The AnnouncementControllerMessenger type export was renamed to AnnouncementMessenger, but the old name is preserved as an alias.

References

Relates to #4538

Changelog

See changelog in diff

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Rename `ControllerMessenger` to `Messenger` in the `@metamask/announcement-controller`
package. The `AnnouncementControllerMessenger` type export was renamed to
`AnnouncementMessenger`, but the old name is preserved as an alias.

Relates to #4538
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No export changes, they are all preserved. The export was converted to a map in order to more easily add an alias. This way is easier to read anyway.

@Gudahtt Gudahtt marked this pull request as ready for review December 20, 2024 06:47
@Gudahtt Gudahtt requested review from a team as code owners December 20, 2024 06:47
@Gudahtt Gudahtt changed the title chore(accouncement): Rename ControllerMessenger to Messenger. chore(accouncement): Rename ControllerMessenger to Messenger Dec 20, 2024
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants