Expose error in NetworkController:rpcEndpointUnavailable event #5501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the client we want the ability to decide whether or not to create a Segment error when a request to Infura fails too many times in a row. Specifically, we want to be able to ignore connection errors. To accommodate this: - Expose the error that was encountered while making the request in the `NetworkController:rpcEndpointUnavailable` event data. - Export `isConnectionError` from `RpcService`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
In the clients we want the ability to decide whether or not to create a Segment error when a request to Infura fails too many times in a row. Specifically, we want to be able to ignore connection errors, as they may indicate that the user is offline, in which case we don't need to fail over to Quicknode.
To accommodate this need:
NetworkController:rpcEndpointUnavailableevent data.isConnectionErrorfromRpcService.References
Progresses #5493.
Changelog
(Updated in PR.)
Checklist