Skip to content

fix: broken commit range due to uninitialized variable #5597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xwitty
Copy link

@0xwitty 0xwitty commented Apr 6, 2025

Explanation

While running the script, I noticed the commit range was sometimes incorrect — e.g., showing ..HEAD instead of the expected tag..HEAD. Turns out latest_release_commit was being used inside determine-commit-range without being passed in, so it was empty. I fixed this by passing it explicitly as an argument.

Also cleaned up a stray quote in the USAGE output.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant