refactor(phishing-controller): enhance URL validation and caching in … #5688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The bulk URL scanning functionality in PhishingController previously didn't leverage the URL scan cache that was already implemented for single URL scanning. This meant that even if a URL had been recently scanned, it would be scanned again when included in a bulk scan request, causing unnecessary API calls and increased response times.
This PR extends the caching functionality to the
bulkScanUrls
method, allowing it to:This optimization significantly reduces API calls and improves response times for bulk scan operations, especially when the same URLs are frequently scanned.
References
Related to #5625 (Add URL scan cache functionality)
Extends functionality from #5682 (Add bulk scan functionality)