Skip to content

fix: correct typos in code comments #6740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −4
Open

fix: correct typos in code comments #6740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f02e0c0
Update PermissionController.ts
viktorking7 Sep 27, 2025
0a70143
Update ARCHITECTURE.md
viktorking7 Sep 27, 2025
62499c7
Update typing.ts
viktorking7 Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/accounts-controller/src/typing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type IsAccountControllerState<Type extends AccountsControllerState> = Type;
*/
export type StrictInternalAccount = Omit<InternalAccount, 'options'> & {
// Use stricter options, which are relying on `Json` (which sometimes
// cause compiler errors because of instanciation "too deep".
// cause compiler errors because of instantiation "too deep".
// In anyway, we should rarely have to use those "untyped" options.
options: {
entropy?: KeyringAccountEntropyOptions;
Expand Down
2 changes: 1 addition & 1 deletion packages/permission-controller/ARCHITECTURE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ console.log(existingPermissions)
### Requesting permissions incrementally

```typescript
// Given an artifically truncated permission state of:
// Given an artificially truncated permission state of:
// {
// 'metamask.io': {
// wallet_getSecretArray: {
Expand Down
4 changes: 2 additions & 2 deletions packages/permission-controller/src/PermissionController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,15 +280,15 @@ export type HasPermission = {
};

/**
* Directly grants given permissions for a specificed origin without requesting user approval
* Directly grants given permissions for a specified origin without requesting user approval
*/
export type GrantPermissions = {
type: `${typeof controllerName}:grantPermissions`;
handler: GenericPermissionController['grantPermissions'];
};

/**
* Directly grants given permissions for a specificed origin without requesting user approval
* Directly grants given permissions for a specified origin without requesting user approval
*/
export type GrantPermissionsIncremental = {
type: `${typeof controllerName}:grantPermissionsIncremental`;
Expand Down