Skip to content

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Oct 17, 2025

Explanation

This replaces the sseEnabled flag with a record that also includes the minimum required client version. This ensures that older clients are not affected when we enable SSE in the future

New flag format

sse: {
  enabled: true,
  minimumVersion: "13.8.0"
}

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Replace sseEnabled with sse { enabled, minimumVersion } and gate SSE by client version; make clientVersion required in BridgeController and update validators/tests accordingly.

  • Bridge Controller:
    • BREAKING: Require clientVersion in BridgeController constructor; propagate to API calls and tests.
    • SSE Gating: Replace sseEnabled with sse { enabled, minimumVersion }; add hasMinimumRequiredVersion and use it to decide streaming; update flag access in controller.
    • Validation/Schema: Add VersionStringSchema; change PlatformConfigSchema to sse object with minimumVersion and remove sseEnabled.
    • Tests: Update unit tests to new SSE config and client version checks; add cases for SSE enabled/disabled by version; refactor setups.
  • Bridge Status Controller:
    • Tests: Fix BridgeController initialization by passing clientVersion.
  • Changelogs: Note breaking constructor change and new SSE flag format.

Written by Cursor Bugbot for commit 6e55d3e. This will update automatically on new commits. Configure here.

@micaelae micaelae requested a review from a team as a code owner October 17, 2025 19:51
@micaelae micaelae requested a review from a team as a code owner October 17, 2025 19:53
cursor[bot]

This comment was marked as outdated.

@micaelae micaelae enabled auto-merge (squash) October 17, 2025 20:29
@micaelae micaelae merged commit 9e1b44d into main Oct 17, 2025
250 of 251 checks passed
@micaelae micaelae deleted the swaps-add-minVersion-to-sse-flag branch October 17, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants