-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add automated dependency bump checker and changelog validator #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cryptodev-2s
wants to merge
17
commits into
main
Choose a base branch
from
feat/add-dependency-bump-checker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7,666
−335
Draft
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
71ff282
feat: add automated dependency bump checker and changelog validator
cryptodev-2s 8ee555d
refactor: inline package name resolution during diff parsing
cryptodev-2s 084415e
refactor: use example repo name instead of core
cryptodev-2s 2a87c2e
fix: remove useless re-exported types
cryptodev-2s 88d116a
docs: add changelog entry for check-deps command
cryptodev-2s 044b46e
fix: correct changelog entry order - BREAKING first, then deps
cryptodev-2s ccc66e2
fix: distinguish BREAKING entries when matching changelog entries
cryptodev-2s 48221f2
fix: show correct section name in changelog validation error
cryptodev-2s 045331a
feat: support renamed packages in changelog validation
cryptodev-2s 8af5181
fix: include packageRename in second parseChangelog call
cryptodev-2s 19c3ccd
fix: detect non-scoped package dependency changes
cryptodev-2s 0d1de51
tests: add functional tests (#189)
cryptodev-2s 49b197d
Fix optionalDependencies incorrectly attributed to dependencies section
cryptodev-2s b53e89c
Fix operator precedence in section boundary check
cryptodev-2s 2f73bd8
Fix default branch check to use defaultBranch parameter instead of ha…
cryptodev-2s 259d980
Reset section state when parsing new file in diff
cryptodev-2s 703e1c3
Fix check-deps command usage in CHANGELOG
cryptodev-2s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how we'd call the script from other repos? How is that possible when this isn't registered in
package.jsonas abinscript?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command was incorrect, this step is actually handled by the create-release-branch CLI. I’ve just fixed the changelog accordingly.
By the way, I’m in the process of moving this over to auto-changelog instead. Here’s the draft PR: MetaMask/auto-changelog#267, I’ll mark it ready shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, didn't see this comment until now. Maybe this should be moved back into draft then?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I will move it back to draft and apply all the suggestions you mentioned here. They are also relevant for auto-changelog, since much of the logic is moved.
Thank you for the review!