refactor: remove ArgsEqualityCheckEnforcer and aggregator whitelist from DelegationMetaSwapAdapter #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom DelegationMetaSwapAdapter - Remove argsEqualityCheckEnforcer requirement from delegations - Remove aggregator whitelist functionality (isAggregatorAllowed) - Simplify swapByDelegation function by removing _useTokenWhitelist parameter - Update constructor to remove argsEqualityCheckEnforcer parameter - Remove _validateTokens and updateAllowedAggregatorIds functions - Update all tests to reflect changes - Update deployment script
Remove test_revert_swapByDelegation_tokenFromNotAllowed and test_revert_swapByDelegation_tokenToNotAllowed tests since token whitelist validation was removed from the contract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the ArgsEqualityCheckEnforcer requirement and aggregator whitelist functionality from the DelegationMetaSwapAdapter contract to simplify the swap delegation flow.
DelegationMetaSwapAdapter: 0xB457CE3b5b6B6449B6d3CA08D498BAc9D8407045
Changes
Contract ()
argsEqualityCheckEnforcerimmutable state variableisAggregatorAllowedmapping (aggregator whitelist)WHITELIST_ENFORCEDandWHITELIST_NOT_ENFORCEDconstants_argsEqualityCheckEnforcerparameterswapByDelegationfunction by removing_useTokenWhitelistparameter_validateTokens()functionupdateAllowedAggregatorIds()functionSetArgsEqualityCheckEnforcer,ChangedAggregatorIdStatusMissingArgsEqualityCheckEnforcer,AggregatorIdIsNotAllowedTests & Deployment
swapByDelegationcalls to remove whitelist parameterImpact
isTokenAllowed) remains but is not enforced (can be removed in future if not needed)Testing
All existing tests pass with the modifications. The contract compiles successfully with no linter errors.