fix: revert removing params as part of #198 #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts back the params being removed in 5d97ef7 as it was a breaking change.
Gudahtt
approved these changes
May 23, 2024
There was a problem hiding this comment.
LGTM!
It seems a bit ambiguous to me whether this was breaking or not. This request is internal to the library, and I would not expect any external system to treat it differently (though it's possible of course). Even if an external system did treat it differently, this certainly wasn't a part of the library's public API or part of any documented behavior.
Definitely an unexpected functional change though, so either way, merging this and shipping it as v9.0.2 sounds good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts back the params being removed in 5d97ef7 as it was a breaking change.