Fix/create release pr GitHub action 2 #93
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| # Initialize branch names | ||
| local release_branch_name changelog_branch_name version_bump_branch_name | ||
| local previous_release_branch_name release_branch_name changelog_branch_name version_bump_branch_name | ||
| previous_release_branch_name=$(get_release_branch_name "$PLATFORM" "$PREVIOUS_VERSION") |
There was a problem hiding this comment.
Bug: Incorrect Branch Name Calculation
The previous_release_branch_name is incorrectly calculated using the current TEST_ONLY flag. When get_release_branch_name is called with $PREVIOUS_VERSION, it uses the current TEST_ONLY environment variable to determine the branch prefix (e.g., "release-testing/" vs "release/"). This is problematic because the previous release branch might have been created with a different TEST_ONLY setting. Consequently, the script attempts to find a non-existent branch (e.g., "release-testing/7.7.0" when the actual branch is "release/7.7.0"), causing operations like yarn run gen:commits to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.