Skip to content

Fix/reanimated#726

Closed
brianacnguyen wants to merge 6 commits intomainfrom
fix/reanimated
Closed

Fix/reanimated#726
brianacnguyen wants to merge 6 commits intomainfrom
fix/reanimated

Conversation

@brianacnguyen
Copy link
Contributor

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen requested a review from a team as a code owner June 5, 2025 22:52
@brianacnguyen brianacnguyen marked this pull request as draft June 5, 2025 22:52
@brianacnguyen
Copy link
Contributor Author

@metamask-bot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

📖 Storybook Preview

@socket-security
Copy link

socket-security bot commented Jun 5, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedreact-native-reanimated@​3.3.0 ⏵ 3.18.09810091 +6100100

View full report

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

📖 Storybook Preview

@brianacnguyen brianacnguyen marked this pull request as ready for review June 5, 2025 23:19
@brianacnguyen brianacnguyen changed the title Draft: Fix/reanimated Fix/reanimated Jun 5, 2025
@brianacnguyen
Copy link
Contributor Author

@metamask-bot publish-preview

@georgewrmarshall
Copy link
Contributor

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/design-system-react": "0.0.0-preview.232346e",
  "@metamask-previews/design-system-react-native": "0.0.0-preview.232346e",
  "@metamask-previews/design-system-tailwind-preset": "0.4.0-preview.232346e",
  "@metamask-previews/design-system-twrnc-preset": "0.0.0-preview.232346e",
  "@metamask-previews/design-tokens": "7.1.0-preview.232346e"
}

@michaelmccallam michaelmccallam requested a review from Copilot June 6, 2025 12:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes and updates the react-native-reanimated dependency across packages to ensure consistency and proper peer dependency management.

  • In design-system-react-native, react-native-reanimated is removed from dependencies, added to devDependencies at v^3.17.0 and to peerDependencies at >=3.3.0.
  • In storybook-react-native, the react-native-reanimated version is bumped from 3.3.0 to ^3.17.0.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/design-system-react-native/package.json Move react-native-reanimated into devDependencies and peerDependencies and bump version
apps/storybook-react-native/package.json Update react-native-reanimated to ^3.17.0 in dependencies

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@brianacnguyen
Copy link
Contributor Author

@metamaskbot publish-preview

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


Was this report helpful? Give feedback by reacting with 👍 or 👎

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

📖 Storybook Preview

@brianacnguyen
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/design-system-react": "0.0.0-preview.f289564",
  "@metamask-previews/design-system-react-native": "0.0.0-preview.f289564",
  "@metamask-previews/design-system-tailwind-preset": "0.4.0-preview.f289564",
  "@metamask-previews/design-system-twrnc-preset": "0.0.0-preview.f289564",
  "@metamask-previews/design-tokens": "7.1.0-preview.f289564"
}

@brianacnguyen brianacnguyen deleted the fix/reanimated branch June 11, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants